Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeQL recommendations #1218

Merged
merged 9 commits into from
Oct 8, 2022
Merged

CodeQL recommendations #1218

merged 9 commits into from
Oct 8, 2022

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Oct 8, 2022

No description provided.

@dacbd dacbd temporarily deployed to internal October 8, 2022 20:02 Inactive
dacbd
dacbd commented Oct 8, 2022
View reviewed changes
src/drivers/github.js Outdated Show resolved Hide resolved
@dacbd dacbd temporarily deployed to internal October 8, 2022 20:04 Inactive
@dacbd dacbd requested a review from a team October 8, 2022 20:05
@dacbd dacbd added technical-debt Refactoring, linting & tidying p2-nice-to-have Low priority labels Oct 8, 2022
0x2b3bfa0
0x2b3bfa0 previously approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dacbd dacbd temporarily deployed to internal October 8, 2022 20:20 Inactive
@dacbd dacbd temporarily deployed to internal October 8, 2022 20:26 Inactive
@dacbd dacbd temporarily deployed to internal October 8, 2022 20:39 Inactive
@dacbd dacbd temporarily deployed to internal October 8, 2022 20:47 Inactive
@dacbd
Revert things
34c8301 
This reverts commit df90c98.

This reverts commit f11c8ae.

This reverts commit 39d0a45.
@dacbd dacbd temporarily deployed to internal October 8, 2022 21:53 Inactive
dacbd
dacbd commented Oct 8, 2022
View reviewed changes
bin/cml/asset/publish.js Outdated Show resolved Hide resolved
@dacbd dacbd temporarily deployed to internal October 8, 2022 21:57 Inactive
@dacbd dacbd requested a review from 0x2b3bfa0 October 8, 2022 22:04
@dacbd
Copy link
Contributor Author

dacbd commented Oct 8, 2022

well CodeQL caught a slightly related bug 🙃

@0x2b3bfa0 0x2b3bfa0 merged commit c97e548 into master Oct 8, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the codeql-changes branch October 8, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Low priority technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dacbd @0x2b3bfa0